schemachanger: add error-on-fallthrough guards on vistors#169359
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom May 1, 2026
Merged
schemachanger: add error-on-fallthrough guards on vistors#169359trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Contributor
|
😎 Merged successfully - details. |
Member
|
This change is |
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
bghal
force-pushed
the
schemachanger-error-fallthrough
branch
from
6b497b8 to
9796f77
Compare
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
bghal
force-pushed
the
schemachanger-error-fallthrough
branch
from
9796f77 to
4f8068b
Compare
The issue in cockroachdb#169345 demonstrated the risk of switch statements on types if an unexpected type is passed to the vistor function. This change guards against future bugs by adding errors-on-default that trip on unexpected types. Epic: CRDB-31325 Informed by: cockroachdb#169345 Release note: None
bghal
force-pushed
the
schemachanger-error-fallthrough
branch
from
4f8068b to
cd36d28
Compare
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/cd36d28/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/cd36d28b77d439fd762a6795ca1fa90a4128d2d0/bin/pkg_sql_tests benchdiff/cd36d28/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/cd36d28/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/bca92f3/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/bca92f3b0e140f41ea2911e939d698e68eae8b06/bin/pkg_sql_tests benchdiff/bca92f3/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/bca92f3/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: # NB: for best (most stable) results, also add a suitable `--benchtime` that
# results in ~1s to ~5s of benchmark runs. For example, if ops average ~3ms, a
# benchtime of `1000x` is appropriate.
#
# Some benchmarks (in particular BenchmarkSysbench) output additional memory
# profiles covering only the execution (excluding the setup/teardown) - those
# should be preferred for analysis since they more closely correspond to what's
# reported as B/op and alloc/op.
benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=bca92f3 --new=cd36d28 --memprofile ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/cd36d28/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/cd36d28b77d439fd762a6795ca1fa90a4128d2d0/bin/pkg_sql_tests benchdiff/cd36d28/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/cd36d28/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/bca92f3/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/bca92f3b0e140f41ea2911e939d698e68eae8b06/bin/pkg_sql_tests benchdiff/bca92f3/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/bca92f3/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: # NB: for best (most stable) results, also add a suitable `--benchtime` that
# results in ~1s to ~5s of benchmark runs. For example, if ops average ~3ms, a
# benchtime of `1000x` is appropriate.
#
# Some benchmarks (in particular BenchmarkSysbench) output additional memory
# profiles covering only the execution (excluding the setup/teardown) - those
# should be preferred for analysis since they more closely correspond to what's
# reported as B/op and alloc/op.
benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=bca92f3 --new=cd36d28 --memprofile ./pkg/sql/tests🔴 Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/cd36d28/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/cd36d28b77d439fd762a6795ca1fa90a4128d2d0/bin/pkg_sql_tests benchdiff/cd36d28/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/cd36d28/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/bca92f3/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/bca92f3b0e140f41ea2911e939d698e68eae8b06/bin/pkg_sql_tests benchdiff/bca92f3/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/bca92f3/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: # NB: for best (most stable) results, also add a suitable `--benchtime` that
# results in ~1s to ~5s of benchmark runs. For example, if ops average ~3ms, a
# benchtime of `1000x` is appropriate.
#
# Some benchmarks (in particular BenchmarkSysbench) output additional memory
# profiles covering only the execution (excluding the setup/teardown) - those
# should be preferred for analysis since they more closely correspond to what's
# reported as B/op and alloc/op.
benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=bca92f3 --new=cd36d28 --memprofile ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/cd36d28b77d439fd762a6795ca1fa90a4128d2d0/25219761023-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/bca92f3b0e140f41ea2911e939d698e68eae8b06/25219761023-1/\* old/built with commit: cd36d28b77d439fd762a6795ca1fa90a4128d2d0 |
cockroach-teamcity
added
the
X-perf-check
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue in #169345 demonstrated the risk of switch statements on types
if an unexpected type is passed to the vistor function. This change
guards against future bugs by adding errors-on-default that trip on
unexpected types.
Epic: CRDB-31325
Informed by: #169345
Release note: None